chore(*): remove btcd support #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor notifier init merge reporter block handles
gitferry
approved these changes
Aug 28, 2024
config/bitcoin.go
Outdated
| WalletEndpoint string `mapstructure:"wallet-endpoint"` | ||
| WalletPassword string `mapstructure:"wallet-password"` | ||
| WalletName string `mapstructure:"wallet-name"` | ||
| WalletCAFile string `mapstructure:"wallet-ca-file"` |
| ZmqTxEndpoint string `mapstructure:"zmq-tx-endpoint"` | ||
| DisableClientTLS bool `mapstructure:"no-client-tls"` | ||
| CAFile string `mapstructure:"ca-file"` | ||
| Endpoint string `mapstructure:"endpoint"` |
There was a problem hiding this comment.
Is there now a difference between endpoint and wallet-endpoint ? or wallet-endpoint was supossed to be used to handle situations where there are multiple wallets loaded i.e the things with Endpoint + "/wallet/" + WalletName ?
There was a problem hiding this comment.
@KonradStaniec yeah, wallet-endpoint is not used so I'll be removing it, but we do use cfg.Endpoint + "/wallet/" + cfg.WalletName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to remove support for
btcdwe will be only usingbitcoindas our backend.References issue.